Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle :log_if in Proxy constructors #23

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Handle :log_if in Proxy constructors #23

merged 1 commit into from
Nov 24, 2022

Conversation

solnic
Copy link
Member

@solnic solnic commented Nov 24, 2022 •
edited
Loading

This should be consolidated eventually, unfortunately the stdlib constructor got in the way 🙂 Anyhow, this fixes a bug where passing log_if as a kwarg option to add_backend with an external logger that should be proxied, would end up not setting this option on the proxy itself.

So, now this works:

Dry.Logger(:test).add_backend(Rollbar, log_if: :exception?)

@solnic solnic merged commit 8c6f43d into main Nov 24, 2022
@solnic solnic deleted the fix-log-if-options-in-proxy branch November 24, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@solnic